cometd/dojo-maven

Maven artefacts for Dojo 1.11.1 release omits the new flat theme

Closed this issue · 10 comments

k-wall commented

Hi all,

I notice that the new maven artefacts produced for Dojo 1.11.1 are missing the 'flat' theme that is present in the distribution http://download.dojotoolkit.org/release-1.11.1/dojo-release-1.11.1.zip.

I am referring to directory:

dojo-release-1.11.1/themes/flat/

Is there a reason why this is so? Why is the maven artefact simply not the artefact produced by dojotoolkit.org?

We are very keen to use the flat theme so it would be appreciated if this could be corrected.

Thanks for maintaining these artefacts.

Keith.

sbordet commented

I just downloaded the dojo-war-1.11.1.war from Maven Central and it does contain the themes/flat directory.

k-wall commented

The files are missing from dojo-1.11.1-distribution.zip.

sbordet commented

I don't understand ? They are present in dojo-1.11.1-distribution.zip, and we just repackage the distribution into a war format, so it all looks good to me.

k-wall commented

I don't see them. Comparing the artefact from Maven central with the one from Dojo:

Maven:
unzip -l ~/.m2/repository/org/dojotoolkit/dojo/1.11.1/dojo-1.11.1-distribution.zip | grep flat
(nothing)

curl -O http://download.dojotoolkit.org/release-1.11.1/dojo-release-1.11.1.zip
unzip -l dojo-release-1.11.1.zip | grep flat
0 03-29-16 23:59 dojo-release-1.11.1/themes/flat/
2823 03-29-16 23:59 dojo-release-1.11.1/themes/flat/flat_dijit_rtl.css
6922 03-29-16 23:59 dojo-release-1.11.1/themes/flat/flat_rtl.css
34074 03-29-16 23:59 dojo-release-1.11.1/themes/flat/flat_dijit.css
0 03-29-16 23:59 dojo-release-1.11.1/themes/flat/dijit/
0 03-29-16 23:59 dojo-release-1.11.1/themes/flat/dijit/Editor_rtl.css
157 03-29-16 23:59 dojo-release-1.11.1/themes/flat/dijit/TitlePane_rtl.css

What I am doing wrong?

sbordet commented

You're doing nothing wrong, the module is repackaging the distribution from Dojo in the wrong way.

sbordet commented

Thanks !

k-wall commented

Thanks for addressing the underlying problem. One question, will artefacts for 1.11.1 at maven central be corrected or will this need to await the next release?

sbordet commented

It's scheduled for the next Dojo release, unless you really need this.
What would be a good numbering scheme here ? 1.11.1.1 ?

k-wall commented

We will await the next Dojo maintenance release. Thanks again.

sbordet commented

Released 1.11.2.