Comma uses wrong comma block on single table inheritance in Rails

Question

Comma uses wrong comma block on single table inheritance in Rails

chrisdb opened this issue 11 years ago · 7 comments

If a comma block is defined on a super class, but missing in one sub class, the comma block from a wrong subclass is used, instead of the one from the super class.
This behaviour only occurs in a Rails / Active Record environment and is not a general inheritance problem.
To reproduce, execute the tests I added in this commit:
chrisdb@508c159

Answer 1 · 2015-03-13T14:19:13.000Z

Any chance to get this fixed?

Answer 2 · 2015-04-05T05:27:24.000Z

Fixed and released version 3.2.3.

Thank you for reporting and specs.

Answer 3 · 2015-04-07T11:38:27.000Z

Thanks for fixing!

Answer 4 · 2015-04-07T13:20:20.000Z

Hmm - sorry to bother but the fix breaks existing code for me.
We have three classes: Customer, which is the parent, Buyer and Seller. Buyer and Seller inherit from Customer. Within Customer we define two comma blocks, one without scope and one with scope :newsletter. Before the patch I could call some_sellers_list.to_comma(style: :newsletter) and that would in turn call the parent class implementation. Now I get an error No comma format for class Seller defined for style newsletter - This is something the specs from @chrisdb did not cover...

Answer 5 · 2015-04-07T14:40:14.000Z

@bvogel can you try eitoball@36eabb5 and check if spec in this change cover your case?

Answer 6 · 2015-04-07T21:13:16.000Z

@eitoball that version seems to do the trick. Thanks for looking into this.

Answer 7 · 2015-04-08T02:42:26.000Z

Released version 3.2.4. Thx for reporting.