commercetools/commercetools-ios-sdk

Private JSONDecoder, Encoder and related

t0rn opened this issue · 3 comments

t0rn commented

Currently jsonDecoder, jsonEncoder, date formatters (Commercetools.swift:216 ) are internal.
Could you make them public?
Actually I want reuse them because of the other issue. It's impossible to catch decoding error because of handling error Result.swift:107 is just logging to console.
I tried to convert your Result type to Swift.Result with concrete error related to decoding, but it's impossible without copying your json decoder implementation.

nikola-mladenovic commented

Hi @t0rn , do you have an example where the encoding / decoding fails?

t0rn commented

Hi @t0rn , do you have an example where the encoding / decoding fails?

Hi. No, but I want to catch it when it happens

nikola-mladenovic commented

Got it, thanks 👍

As you've probably seen, it's been a couple of years since the last release, swift continued evolving, and even though the SDK should be completely functional / usable, further changes aren't planned at this point.

If you have a potential project that would benefit from some additions like this, I'd suggest to bring it up during your project trial period.