commercialhaskell/stackage-server

Missing ubuntu-mono font

Closed this issue · 10 comments

mitchellwrosen commented

<pre> tags are styled with

font-family: "ubuntu mono", "Monaco" !important;

but I don't have this font installed, so code blocks are being rendered in some non-monospaced default font. Is there any way to instead fall back on a font-family: monospaced instead?

qrilka commented

This one is big argument to prefer hackage haddocks over ones from stackage, at least for me

snoyberg commented

Chris is on vacation, but I can probably push a fix later today. If someone
wants to send a PR to include a better monospace fallback, I'll be able to
merge that pretty quickly.

On Fri, Sep 23, 2016, 9:52 AM Kirill Zaborsky notifications@github.com
wrote:

This one is big argument to prefer hackage haddocks over ones from
stackage, at least for me

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADBBzNAUU6IYHrs2cwUNwgGHJOKmgToks5qs3cVgaJpZM4J3I2N
.

snoyberg commented

The changes are deployed on our CI server, and monospace is now included in
the fallback. If one of you can confirm that this fixes the problem for
you, I can merge to the prod branch.

On Fri, Sep 23, 2016 at 10:06 AM, Michael Snoyman michael@snoyman.com
wrote:

Chris is on vacation, but I can probably push a fix later today. If
someone wants to send a PR to include a better monospace fallback, I'll be
able to merge that pretty quickly.

On Fri, Sep 23, 2016, 9:52 AM Kirill Zaborsky notifications@github.com
wrote:

This one is big argument to prefer hackage haddocks over ones from
stackage, at least for me

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADBBzNAUU6IYHrs2cwUNwgGHJOKmgToks5qs3cVgaJpZM4J3I2N
.

qrilka commented

@snoyberg any pointers to the CI server where I could check that?

snoyberg commented

Forgot to copy-paste the link, sorry. https://ci.stackage.org

qrilka commented

That's much better, thanks @snoyberg

snoyberg commented

Cool, I just merged to prod. If in the future you notice possible CSS improvements, don't hesitate to send a PR.

qrilka commented

But @snoyberg there is #200 already

snoyberg commented

I didn't see that, I don't actively monitor this repo usually. I'd have
gone with that instead.

On Fri, Sep 23, 2016, 3:46 PM Kirill Zaborsky notifications@github.com
wrote:

But @snoyberg https://github.com/snoyberg there is #200
#200 already

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADBB1klCi5PC0av5rz_80z0LDNmjP_xks5qs8ofgaJpZM4J3I2N
.

chrisdone commented

👍