commercialhaskell/stackage-server

License display could be improved

dbaynard opened this issue · 5 comments

dbaynard commented

SPDX support for licenses is not quite right.

For example, ucam-webauth-types can be licensed under BSD3 or Apache 2.0.

The license field is described in hpack and cabal formats respectively, as

license: BSD-3-Clause OR Apache-2.0

and

license:        (BSD-3-Clause OR Apache-2.0)

This is then displayed on stackage (and packdeps.haskellers.com) as

BSD3ClauseORApache20 licensed…

Hackage correctly displays this as

License

(BSD-3-Clause OR Apache-2.0)

snoyberg commented

I think I've addressed the problem in the code at commercialhaskell/all-cabal-tool@114155a. Now I just need to regenerate all of the files and get the changes onto Github so that Stackage Server can pick them up.

snoyberg commented

This should be displaying correctly now, can you confirm?

dbaynard commented

Looks good! Thanks. What about packdeps.haskellers.com? That still has the old display — does it require code changes, too?

Edit: e.g. https://packdeps.haskellers.com/licenses/ucam-webauth

snoyberg commented

Yes, it did, and should be addressed now. Thanks for pointing that out too!

dbaynard commented

Great, that too. Thank you