View's `frame` setter has different scaling from `frame` init argument

[egorzhdan]

I've configured 200% scaling in Windows settings, and some components in UICatalog now look misplaced:

The image view, and the table view cells look unexpectedly. Frame for these components is set via frame property, while for the others frame initializer argument is used.

Looks like the coordinates & dimensions for these components should have been multiplied by 2.
Perhaps View.frame.didSet should perform scaling differently?

[compnerd]

The rendering definitely indicates something is wrong. However, I'm not sure where this would be going wrong.

https://github.com/compnerd/swift-win32/blob/master/Sources/SwiftWin32/UI/View.swift#L113-L125
This indicates that the frame setter does scale the new frame for the DPI

This matches the operations in the initializer:
https://github.com/compnerd/swift-win32/blob/master/Sources/SwiftWin32/UI/View.swift#L186-L193

[compnerd]

Playing around with this since I happened to get some scaling when remoting - it seems that its not the fact that we are setting the frame rect via the frame var I think. It is the resizing that occurs during the reparenting:

https://github.com/compnerd/swift-win32/blob/master/Sources/SwiftWin32/UI/View.swift#L291-L294

The client has already been scaled and sized, but the reparenting will result in the view actually getting resized back. However, failure to do perform this step fails to correctly size the buttons in Calculator. Without this operation though, the list view is nearly correct, except the offsets for the rows are incorrect.

[egorzhdan]

Ah, that makes sense. Thanks for the explanation!