Incorrect lcm result

Question

Closed this issue 4 years ago · 5 comments

I recently ran into a case where lcm was returning the incorrect result. The numbers 186028, 193052 and 144624, as computed by:

const lcm = require('compute-lcm');
console.log(lcm(186028, 193052, 144624));

reports the result 108206102374928, however the correct answer is 324618307124784.

Answer 1 · 2020-11-29T05:59:56.000Z

@sgerace Thanks for reporting. Was able to reproduce. Seems to stem from a bug in the gcd implementation.

A patch submitted against gcd should resolve the issue.

Answer 2 · 2020-11-29T06:03:53.000Z

This bug is not present in the stdlib implementation.

We will, however, push a patch to gcd.

Answer 3 · 2020-11-29T06:10:26.000Z

This was fixed in gcd. @sgerace Can you reinstall your node_modules dependencies and confirm that the issue is resolved?

Answer 4 · 2020-11-29T06:15:41.000Z

The gcd dep version has been updated, a test case added, and a new version published. Closing as resolved.

Thank you, @sgerace, for reporting and @Planeshifter for fixing.

Answer 5 · 2020-11-30T13:54:30.000Z

Hi @kgryte, thanks for the quick response. I can confirm that the issue has been fixed in 1.1.2.