Clean up feedstocks still using `conda-forge-ci-setup=3`
Opened this issue ยท 6 comments
I noticed this in pytorch, and according to a search for this, we have around 10 feedstocks that are currently affected.
The problem with this is that using such an old ci-setup forces a very old conda-build, which is - pretty much by sheer luck - just barely new enough to correctly handle {{ stdlib("c") }}
, which we need to avoid creating packages with incorrect metadata on osx/linux.
There are many other relevant changes that should make us retry to make these feedstocks use up-to-date build tools (some may still need to keep pinning lief due to various issues, but aside from a performance regression on osx, lief 0.14 should have fixed most things).
- atheris @conda-forge/atheris
- ifcopenshell @conda-forge/ifcopenshell
- libignition-common @conda-forge/libignition-common
- orocos-kdl @conda-forge/orocos-kdl
- pcl @conda-forge/pcl
- python @conda-forge/python
- pytorch @conda-forge/pytorch-cpu
- qt-main @conda-forge/qt-main
- stackvana-afw @conda-forge/stackvana-afw
- tlsh @conda-forge/tlsh
- xgems @conda-forge/xgems
@h-vetinari Okay, so all we need to do is to remove the remote_ci_setup
entries and check to see if all goes well?
We are currently preparing a new release of ifcopenshell
in conda-forge/ifcopenshell-feedstock#54. So I will try to make the changes there to see if that goes well.
Here's what we have. I remember pinning py-lief was necessary way back when due to the osx builds ran out of time. Changing the py-lief version at the time fixed it. Hopefully this is gone now.
Here's the remote_ci_setup
in ifcopenshell
remote_ci_setup:
- conda-forge-ci-setup=3
- py-lief>=0.12.3
pcl, orocos-kdl, libignition-common all done
@h-vetinari ifcopenshell is updated with the outdated configs removed.
tlsh
is fixed (well, building)... I could probably use an assist on conda-forge/atheris-feedstock#16 (my c++ chops are non-existent):
src/native/counters.cc:26:6: error: variable or field '__sanitizer_cov_8bit_counters_init' declared void
26 | void __sanitizer_cov_8bit_counters_init(uint8_t* start, uint8_t* stop);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/native/counters.cc:26:41: error: 'uint8_t' was not declared in this scope
26 | void __sanitizer_cov_8bit_counters_init(uint8_t* start, uint8_t* stop);
| ^~~~~~~
src/native/counters.cc:24:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
23 | #include "macros.h"
+++ |+#include <cstdint>
@bollwyvl: this patch should fix it: https://patch-diff.githubusercontent.com/raw/google/atheris/pull/91.patch
Thanks! Still seeing some OSX issues on atheris
(but not missing libfuzzer
, which was happening previously)