conda-forge/docker-images

why is make necessary

hmaarrfk opened this issue · 6 comments

Is make necessary in the docker image?

It seems we can always add it to the conda dependencies right?

I think this is hiding a few unlisted dependencies on make :/

I'm just going to document the packages that need updating here, if you want to remove make from the dependency, we will have to issue udpates to them:

  • expat-feedstock
  • libtool-feedstock
  • ncurses-feedstock
  • rhash-feedstock
  • texinfo-feedstock
  • readline-feedstock
  • libffi-feedstock
  • libedit-feedstock
  • yaml-feedstock
  • patchelf-feedstock
  • openblas-feedstock
  • lz4-c-feedstock
  • lzo-feedstock (has it listed as cmake.... but clearly that should be make)
  • icu-feedstock
  • libpng-feedstock
  • jpeg-feedstock

This has been around since we moved the Docker image over here. So nearly 3 years ago! 😲

We didn't have a package for make at the time. In fact, we added make nearly 1 year later.

Anyways people have been adding make during the rebuild and encouraging it on new recipes. I'm sure we can remove it once we've gotten the remain things to include it as a requirement.

There's probably a few other things like this we should revisit.

xref: #5

Got it. Thanks. I just figured I would document whatever I had to change to get things to compile.

Added PR ( #94 ) to try dropping make from the Docker images.

As noted in this discussion, make comes preincluded with CentOS 6 x86_64 images. So dropping make from this list doesn't stop it from being there.