xmlns attribute in the .csproj file causes no version information to be found
Closed this issue · 3 comments
ebrown5-captioncall commented
Older versions of .csproj files have this attribute in the Project tag:
xmlns="http://schemas.microsoft.com/developer/msbuild/2003"
When that tag is in my .csproj file, VersionReader doesn't find any version variables.
(I found this from a 4.7 project, editing the file over and over to find what was causing the failure. I don't know how reproducible it actually is)
conficient commented
I'm not sure the tag is needed for 2017-format projects and later, so you should be able to remove it safely. It's adding an XML namespace to the project XML which prevents the xml code from reading the values correctly.
ebrown5-captioncall commented
It still compiles and the solution doesn't complain. I worry it will be restored and break things unexpectedly.
…________________________________
From: Howard Richards ***@***.***>
Sent: Thursday, October 28, 2021 2:45 AM
To: conficient/versionReaderTask ***@***.***>
Cc: Earl Brown ***@***.***>; Author ***@***.***>
Subject: Re: [conficient/versionReaderTask] xmlns attribute in the .csproj file causes no version information to be found (Issue #19)
[EXTERNAL]
I'm not sure the tag is needed for 2017-format projects and later, so you should be able to remove it safely. It's adding an XML namespace to the project XML which prevents the xml code from reading the values correctly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#19 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOHPLAAJFEVQRGWM2LU2K3DUJELTZANCNFSM5GY2OI7A>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
conficient commented
No further activity on this so closing..