confluentinc/kafka-tutorials

Incorrect syntax in tutorial for creating connector

ybyzek opened this issue · 5 comments

CREATE SOURCE CONNECTOR online_dating WITH (
  'connector.class'          = 'PostgresSource',
  'name'                     = 'recipe-postgres-dating',
  'kafka.api.key'            = '<my-kafka-api-key>',
  'kafka.api.secret'         = '<my-kafka-api-secret>',
  'connection.host'          = '<database-endpoint>',
  'connection.port'          = '<database-endpoint>',
  'connection.user'          = '<database-user>',
  'connection.password'      = '<database-password>',
  'database'                 = '<database-name>',
  'table.whitelist'          : 'messages',
  'timestamp.column.name'    : 'created_at',
  'output.data.format'       : 'JSON',
  'db.timezone'              : 'UTC',
  'tasks.max'                : '1'
);

cc: @colinhicks

No other instances were found, based on this check:

grep -ir ":" --include source.sql * 

@ybyzek Should we also change:

-   'connection.port'          = '<database-endpoint>',
+   'connection.port'          = '<database-port>',

@colinhicks I supposed we want to change all of these to [host|port] instead of endpoint?

aviation/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
aviation/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
credit-card-activity/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
credit-card-activity/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
credit-card-activity/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
credit-card-activity/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
customer-journey/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
customer-journey/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
denormalization/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
denormalization/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
discount-promo/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
discount-promo/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
discount-promo/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
discount-promo/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
dynamic-pricing/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
dynamic-pricing/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
dynamic-pricing/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
dynamic-pricing/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
fleet-management/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
fleet-management/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
internet-of-things/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
internet-of-things/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
inventory/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
inventory/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
location-based-alerting/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
location-based-alerting/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'       = '<my-database-endpoint>',
logistics/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
logistics/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
logistics/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
logistics/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
loyalty-rewards/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<database-endpoint>",
loyalty-rewards/confluent/code/tutorial-steps/dev/source.json:  "connection.port"          : "<database-endpoint>",
loyalty-rewards/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<database-endpoint>',
loyalty-rewards/confluent/code/tutorial-steps/dev/source.sql:  'connection.port'          = '<database-endpoint>',
next-best-offer/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
next-best-offer/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
online-dating/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<database-endpoint>",
online-dating/confluent/code/tutorial-steps/dev/source.json:  "connection.port"          : "<database-endpoint>",
online-dating/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<database-endpoint>',
online-dating/confluent/code/tutorial-steps/dev/source.sql:  'connection.port'          = '<database-endpoint>',
payment-status-check/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
payment-status-check/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
payment-status-check/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
payment-status-check/confluent/code/tutorial-steps/dev/source.json:  "connection.host"          : "<my-database-endpoint>",
payment-status-check/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
payment-status-check/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
payment-status-check/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',
payment-status-check/confluent/code/tutorial-steps/dev/source.sql:  'connection.host'          = '<my-database-endpoint>',

@ybyzek at least we are consistent :). I doubt this would confuse many folks as is. I don't feel strongly about changing it.

@colinhicks I've pushed appropriate changes into the linked PR