conlect/image-iiif

Deprecated: Optional parameter $prefix declared before required parameter $identifier is implicitly treated as a required parameter

Closed this issue · 1 comments

jsunier commented

Hi,

I get the following warning when calling the ImageIIIF::info method even providing the two arguments (ex. $file->info('iiif', 'test.jpg')).

Deprecated: Optional parameter $prefix declared before required parameter $identifier is implicitly treated as a required parameter in /app/vendor/conlect/image-iiif/src/ImageIIIF.php on line 85

An easy fix would be to do something like this for the method signature :

public function info(?string $prefix, string $identifier)
{
	$prefix ??= 'iiif';

	// ...
}

If you want i can make you a PR about that 😉

jeremytubbs commented

Thanks for the info, I have decided to make $prefix required on release 1.1.0.

  • 👍1