Build is broken with go 1.16

Question

Build is broken with go 1.16

gnufied opened this issue 4 years ago · 2 comments

We don't have to fix this right away but it looks like builds might be broken in 1.16 because of go module changes.

(cd /home/hekumar/goal/src/github.com/golang/protobuf/ && go get -v -d $(go list -f '{{ .ImportPath }}' ./...)) &&
go build -o "protoc-gen-go" github.com/golang/protobuf/protoc-gen-go
no required module provides package github.com/golang/protobuf/protoc-gen-go: working directory is not part of a module
make[1]: *** [Makefile:66: protoc-gen-go] Error 1
make[1]: Leaving directory '/home/hekumar/goal/src/github.com/container-storage-interface/spec/lib/go'
make: *** [Makefile:36: build] Error 2

Answer 1 · 2021-03-03T03:35:53.000Z

it works by explicitly disabling go modules though:

GO111MODULE=off make

Answer 2 · 2021-03-04T00:05:34.000Z

Thanks for reporting this

…

On Tue, Mar 2, 2021, 10:36 PM Hemant Kumar ***@***.***> wrote: it works by explicitly disabling go modules though: GO111MODULE=off make — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#471 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5KLAHUSXECQJBVTOIJZTTBWVCRANCNFSM4YQKWBTQ> .