containers/buildah

New --exclude directive from Dockerfile

slinkydeveloper opened this issue · 10 comments

Feature request description

Dockerfile recently added support for the COPY --exclude parameter, see https://www.docker.com/blog/new-dockerfile-capabilities-v1-7-0/. Would it be possible to add it to podman too?

Suggest potential solution

A clear and concise description of what you want to happen.

Have you considered any alternatives?

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

You could use docker-buildx (BuildKit), before the feature is available in podman build (Buildah)

This needs to bed enhanced in Buildah

Seems reasonable to me. But would require work in imagebuilder, I blieve.

@nalind @flouthoc WDYT?

If you were interested in opening a PR that would help this along.

Yes imagebuilder changes are needed afaics, I can give this a stab if @slinkydeveloper is not already working on this.

The imagebuilder parts should have landed in openshift/imagebuilder#285.

Nice so this just needs plumbing with buildah and then podman.

A friendly reminder that this issue had no activity for 30 days.

@nalind @flouthoc any progress on this?

Yeah, the main stumbling block I hit is getting the conformance tests to pass, since they're turning up behavior which seems counterintuitive, to me at least, in a few cases.

A friendly reminder that this issue had no activity for 30 days.