go.mod: do not depend on github.com/containers/podman
Luap99 opened this issue · 3 comments
Luap99 commented
Given that podman likely wants to import this go client lib as well (containers/podman#14804) this lib should not depend on any podman code. While it can work the circular dependency is just asking for trouble when podman tries to make breaking changes to the code.
I propose that we move the required podman code to c/common and then podman and conmon-rs can use it without trouble.
saschagrunert commented
Sounds good to me, thank you for taking care of those changes! 🙏
haircommander commented
c/common sounds like a good place! we could also move the code into here to make vendor dancing easier. we only use TerminalSize and kubeutils.HandleResizing
Luap99 commented
utils.CopyDetachable is also used here but this is also no problem I will move the required code to c/common