containers/container-selinux

Branch protection for main branch

Closed this issue · 3 comments

lsm5 commented

@rhatdan We should enable some rules to protect the main branch.

At the very least:

  • Require a pull request before merging
  • Do not allow bypassing the above settings

image

One anomaly I notice is that even though #204 was merged, it's content isn't visible in the main branch and I don't see any PR done to undo those changes. Which makes me suspect a force push probably wiped it out.

lsm5 commented
  • Require a pull request before merging
  • Do not allow bypassing the above settings

I've enabled these 2 rules for now.

lsm5 commented

we should check if more rules can be enabled for better protections.

rhatdan commented

This looks good. I am going to close this issue, since you turned on a couple of protections.

  • 👍1