containous/traefik-extra-service-fabric

Grouped backend labels are incorrect

jjcollinge opened this issue · 0 comments

jjcollinge commented

The docs use the labels:

  • traefik.backend.group.name
  • traefik.backend.group.weight

However in servicefabric_labelfuncs.go on line 11 and 12:

traefikSFGroupName                   = "traefik.servicefabric.groupname"
traefikSFGroupWeight                 = "traefik.servicefabric.groupweight"

This means the grouped labels do not match and canary testing is not possible with the documented labels.

NOTE: For anybody wishing to use this feature before a fix is merged, please use the labels:

  • traefik.servicefabric.groupname
  • traefik.servicefabric.groupweight

I will post a fix shortly.
cc: @lawrencegripper