Review whitelist.txt
Toflar opened this issue · 8 comments
Hey everyone,
I've implemented automated spell checking on meta data (at the moment only title and description are spell checked against) so that we can further improve the quality of our meta data.
It is based on GNU Aspell (http://aspell.net).
There's a whitelist.txt file which contains all exceptions to what Aspell thinks is wrong and for the sake of simplicity I've added everything it found during the first run to that whitelist. So basically the whitelist now certainly contains words that are incorrectly spelled.
It would be great if you could help to review that file and if you find something, create a PR where you:
- remove that word from the
whitelist.txt - fix the issues in the linter finds.
We should not set the hurdle for new commits so high. I do not believe that all users want to install all dictionaries to run the tests and just want to maintain their own native language. What happens if a mistake appears in a language that is foreign to me? The user will probably just give up.
You don‘t have to install anything at all. Just do the changes and create a PR. Travis will then tell you what‘s wrong and you can continue to update your PR to fix the issues.
I think I can only get the first mistake back. That should be very complicated should there be several mistakes.
I could optimize this, that‘s not a problem.
I had a short look to the whitelist. To increase the quality to a next level you might think about providing whitelists for each language.
That's true, should not be a big deal to do, I'll leave the issue open.
Whitelists are now localized, thanks @dmolineus