Rewrite in a clean way DrupalJSONAPIQueryString.js

Question

Rewrite in a clean way DrupalJSONAPIQueryString.js

yann-yinn opened this issue 7 years ago · 8 comments

add some recursivity + enhance units tests with a more complex query

edit : now a npm package https://www.npmjs.com/package/d8-jsonapi-querystring

Answer 1 · 2017-06-24T12:12:17.000Z

Is this something which could be published as a npm package? This could be useful for other implementations as well, I assume?

Answer 2 · 2017-06-24T12:47:11.000Z

@dawehner well i guess there is already an existing package that does that, i have to check :-p

If not, it may be useful for others JS clients to published it as package

Answer 3 · 2017-06-24T12:57:35.000Z

At least in my elm implementation I certainly will write a similar library as well. It is certainly helpful to have a more descriptive way of saying what you want than "JUST" a query string.

…

On Sat, 24 Jun 2017 at 13:47 Yann ***@***.***> wrote: @dawehner <https://github.com/dawehner> well i guess there is already an existing package that does that, i have to check :-p It not, it may be useful for others JS clents and published it as package would be the way — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABz7qoiIWw2DetIQyNptGFeCJe8R-38ks5sHQVQgaJpZM4OETRT> .

Answer 4 · 2017-06-24T13:38:59.000Z

Maybe i miss it but did not found a existing npm package that do this : https://www.npmjs.com/browse/keyword/jsonapi

Answer 5 · 2017-06-25T12:08:34.000Z

Rewritten with a fully recursive function + unit test fixed

Answer 6 · 2017-06-25T12:09:58.000Z

Recursion rulez!

…

On Jun 25, 2017 14:08, "Yann" ***@***.***> wrote: Rewritten with a fully recursive function — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFoqrRvUUdcYUt1yKVG-XZK3vQ6Vxxlks5sHk3DgaJpZM4OETRT> .

Answer 7 · 2017-06-25T18:41:01.000Z

Now a npm package : https://www.npmjs.com/package/d8-jsonapi-querystring

Answer 8 · 2017-06-25T20:16:46.000Z

👏 will you ping the other consumer devs in Slack to let them know about it?

…

On Jun 25, 2017 8:41 PM, "Yann" ***@***.***> wrote: Now a npm package : https://www.npmjs.com/package/d8-jsonapi-querystring — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFoqkYlcEhuUENChn19poLIJUBQbRjsks5sHqm9gaJpZM4OETRT> .