contiamo/operational-ui

Improve DataTable cells

Closed this issue · 12 comments

TejasQ commented

Currently our DataTable has a bit of clunkiness:

image

There's enough room to render a full result, but it doesn't – the default maxCharactersInCell prop kicks in and the contents of a cell truncate for no reason.

I propose we improve this in the following way:

  • If a cell goes past the maxCharactersInCell,
    • add a "more options" icon, that when clicked, (like this
      image)
      • opens a little tooltip/hint/modal with the full contents of the cell
      • it opens wherever there's free space around it
      • the hint closes on click outside
march213 commented

👋🏻 I'd like to take this one too 🤓

TejasQ commented

Wow! You're on fire, @march213! Let's do it!

march213 commented

👋🏻 I'm going to work on this on Thursday.

  • 👍1
TejasQ commented

AWESOME! Thanks so much!

  • 😄1
  • ❤️1
TejasQ commented

@march213 how's progress on this? Can I help with anything?

march213 commented

@TejasQ Oh, I'm sorry, didn't notice this comment. I'm working on right now.

march213 commented

Experienced some problems with starting...

image

image

I've tried to reinstall all of the dependencies and clone the fresh repo.

Here is the log when I stopped it:

✔ Watching Type Declarations and Icons. Took ⚠️  4.58m.

I'll try one more time later.

  • 👍1
TejasQ commented

This is a little more pressing of a task because it directly impacts the usability of this component.

For example:

image

Do you mind if I take it over? You can always watch the issue to see how we fix it.

  • 👍1
march213 commented

@TejasQ Sure! Sorry about that.
I'm not sure what happened and why it's stopped working. I tried to wait ~8 min but nothing happened.

image

Anyway, I don't want to block you and looking forward to contribute more.

march213 commented

@TejasQ Hi 👋🏻. You can take it over. I still have problems with running the project locally.

  • 👍1
TejasQ commented

Great! I'll do it. Let me know if you want to debug your local environment together and we can hop on a call some time this weekend or so. https://calendly.com/tejaskumar/pair-programming?back=1&month=2019-07

march213 commented

@TejasQ It's awesome! Scheduled. And if no-one start working on that, I'd be happy to take it again.

  • 👍1