[BUG]
Opened this issue · 1 comments
Describe the bug
After the CLA has been agreed, the text on the PR's Conversastion page has a confusing bright red warning/error at the end of the comments, saying "All checks have failed".
Apologies inadvance if i've misunderstood something here.
To Reproduce
Enable contributor-assistant/github-action in a github repository as described in documentation.
Create a pull request.
Note that the CLA needs to be agreed.
Add a comment with the required text "I have read the CLA Document and I hereby sign the CLA" as instructed.
We then get these comments on the Conversation page, in this order:
- "CLA Assistant Lite bot All contributors have signed the CLA writing_hand white_check_mark"
- "I have read the CLA Document and I hereby sign the CLA"
- "... has signed the CLA from Pull Request"
- "All checks have failed" in red.
And the PR appears to have been created.
But the "All checks have failed" in red is rather confusing, especially as it is the last item in the conversation.
Expected behavior
The Pull request conversation page should show that the CLA has been agreed and the PR is ok without the bright red warning/error "All checks have failed", or at least show that things are ok below this warning/error text.
Ideally it would show things in this order:
- "All checks have failed" crossed/greyed out to indicate it is out of date.
- "I have read the CLA Document and I hereby sign the CLA"
- "... has signed the CLA from Pull Request"
- "CLA Assistant Lite bot All contributors have signed the CLA writing_hand white_check_mark"
I appreciate that some or all of this ideal behaviour might not be possible.
Screenshots
If applicable, add screenshots to help explain your problem.
I guess this is similar to the bug I have raised #150
@julian-smith-artifex-com, is your master/main branch protected? Click on "Details" of the failed repo and check for more details.
In my case, I need to have my branch protected. I have asked how can we run this action with protected branch