[QA] add phpstan

Question

[QA] add phpstan

f3l1x opened this issue 8 years ago · 6 comments

f3l1x commented 8 years ago

Configuration in the README (https://github.com/phpstan/phpstan).

cc @ondrejmirtes

Answer 1 · 2017-01-08T13:23:58.000Z

@f3l1x I can prepare a PR if you'd like me to.

Answer 2 · 2017-01-08T13:33:32.000Z

@ondrejmirtes Thanks a lot, but it not nescessary. I would like to go throw the readme and handle possible breakpoints by my self. I can provide some feedback after that.

Thank you for your jof on @phpstan. It looks like a great missing tool for PHP world. 👍

Answer 3 · 2017-01-08T13:34:56.000Z

@f3l1x OK, just show me the integration before merging so I can give my 2 cents on it :)

Answer 4 · 2017-06-11T15:26:47.000Z

@ondrejmirtes I've finally integrated it. :-) Good job btw, phpstan's hits are pretty useful and I didn't get lost.

I would be happy if you could take a look.

Answer 5 · 2017-06-11T21:18:19.000Z

@f3l1x Cool, it's nice :) 👍 Are you still extending Nette\Object for BC reasons?

Answer 6 · 2017-06-12T04:05:50.000Z

@ondrejmirtes Well, I do not, but nextras/orm does, so I cannot avoid it.