Release new version supporting nette/forms 3.1.8

Question

Release new version supporting nette/forms 3.1.8

foxycode opened this issue 2 years ago · 6 comments

foxycode commented 2 years ago

I see support for nette/forms version 3.1.8 is already merged to master. Can you please release new version?

Also, is there still need to limit this package to specific version? Wouldn't be ~3.1.7 better?

Answer 1 · 2022-12-13T14:58:37.000Z

~3.1.7 sounds good to me, please prepare PR.

Answer 2 · 2022-12-13T16:53:33.000Z

@f3l1x I thought I have access, can you please allow me push new branches?

Answer 3 · 2022-12-14T15:08:04.000Z

No, please don't do that. This library heavily uses some internal code from nette/forms and because of that it's allways strict on using exact minor version. Having in composer ~ for nette forms is highly dangerous since it could potentially crash current release. @foxycode @f3l1x

Answer 4 · 2022-12-14T15:15:17.000Z

0.5.4 released. I wanted to add build for 8.2 before that and made support for it, but you're rushing into it. You can allways just put ^0.6 in your composer and you'll be on master if it's critical.

Answer 5 · 2022-12-14T15:54:34.000Z

@dakorpar Can you please tell which internal things? Maybe I can speak with David Grudl to fix these things in nette/forms

Answer 6 · 2022-12-15T09:31:11.000Z

There's noting to fix, library itself is using some methods that are marked as @internal those methods can be changed at any minor version, because of nature of this library it's actually built on top of nette/forms and doing some changes on it, it is very dangerous not to have it like that and in the end there's really no need for this.