Tests - basic testing via Nette\Tester

Question

Tests - basic testing via Nette\Tester

Closed this issue 9 years ago · 7 comments

f3l1x commented 9 years ago

Answer 1 · 2015-04-14T10:51:19.000Z

I have some tests in here - https://github.com/haltuf/Gopay
Would it be sufficient?

Answer 2 · 2015-04-14T10:55:38.000Z

@haltuf It looks great.

Could you..?

Split tests and Travis CI
Squash all tests commits to one
Squash all CI commits to one
Add empty line to end of files
Send PR 1 - tests
Send PR 2 - CI

Answer 3 · 2015-04-14T11:14:20.000Z

Sure, I will. Sorry for being dumb, but can you explain/link some info about "Add newline to end of files"?
Does it mean just adding new empty line to every file, or does it mean something more profound?

Answer 4 · 2015-04-14T11:15:30.000Z

Yes, adding new empty line. Sorry for typo.

Answer 5 · 2015-04-14T12:44:29.000Z

I created two branches as requested, but the thing is, unless issue #17 is solved, the tests will fail now (I solved the issue for me, but the solution isn't very good and I would hesitate to commit it)
Do you want me to send PRs anyway or shall we wait until issue #17 is solved?

Answer 6 · 2015-04-17T09:35:56.000Z

@haltuf Thanks. Could you run tests with this branch? https://github.com/f3l1x/Gopay/commits/patch-17 You have to set channels via extensions

    channels:
        gopay: Gopay - Elektronická peněženka

Or manually via $service->addChannel($service::METHOD_CARD_UNICREDITB, 'Gopay - Elektronická peněženka')

Answer 7 · 2015-04-17T10:37:54.000Z

If you manage to merge your changes with haltuf@3cc7297, then now the tests are passing on your branch patch-17.