contributte/gopay

PHP 5.4

Closed this issue · 12 comments

f3l1x commented
  • Short array syntax
  • Traits (maybe)
f3l1x commented

@hranicka @vojtech-dobes @haltuf Are you ok with it?

I lean to be conservative in adopting new features, when it does not have any practical meaning.
Short array syntax is rather cosmetical change, which IMHO only raises requirements (from PHP 5.3 to 5.4)
Traits - I can't say, never used them before. I have some awareness, but no practical experience :-)

hrach commented

The reasons should not be practical, but political - 5.3 is insecure and dangerous. Drop it!

Ok, I had no idea that it is so serious...

hrach commented

Well, we are fighting for better world, don't we? :)

@hrach :smile

In my opinion 5.3 compatibility is not necessary. Also 5.4 has been released 3 years ago and should be installed on almost hosts.

f3l1x commented

I suggest migrate to min 5.4 or even 5.5. For the future.

Regarding people with old PHP: good library can be incentive to upgrade :). I would raise the minimum PHP to 5.4 for now. And then raised it to 5.5 exactly when 5.4's "Security fixes only" phase will end. Which is on 14 Sep 2015.

f3l1x commented

@vojtech-dobes 5.3 will be in "Security fixes only" in 3 months. Don't be better raise it to 5.5 at once?

f3l1x commented

Implemented.