Use different DevServer/Http/Client class
janfejtek opened this issue · 3 comments
The CurlClient class is hard coded in extension.
webpack/src/DI/WebpackExtension.php
Line 92 in e2e7499
Would it be possible to define it in config as well?
My use case is that I need to check REMOTE_ADDR instead of localhost for a running dev server.
Hello,
I'm not sure changing the client implementation is the right place to solve your use case 🤔 The dev server URL is configurable and you should be able to get the REMOTE_ADDR there using dynamic parameters.
But in general, we sure can make it configurable. Could you send a pull request?
You are right, dynamic parameters are nicer solution and it works great. 👍
But just in case somebody needs it in future I will send PR anyway.
Cool, thank you!