control-net/libre-cards-against-humanity

🔹 - Change GetPlayers into a Players property

petrspelos opened this issue · 4 comments

petrspelos commented

Summary

In our ILobby interface we are exposing a GetPlayers method that returns an IEnumerable<Player>. It might be a little more convenient to have a Players property with only a getter to access this collection.

https://github.com/petrspelos/libre-cards-against-humanity/blob/dd943ab10c2276f2dcd5c1787862c706195ee87c/src/LibreCards.Core/ILobby.cs#L14

What needs to be done

The GetPlayers method needs to be changed into a Players property with only a { get; } (getter) and users of this interface need to be adjusted. ☺️

Interested? ❤️

If you'd like to tackle this issue, make sure to comment below so that multiple people don't work on the same issue accidentally. 🌮

Jayita10 commented

I would like to work on this issue

petrspelos commented

Heya, @Jayita10!

Absolutely. ☺️

Go right ahead. Let me know if you need any more info or if you have any questions. 👍

Jayita10 commented

Hi @petrspelos, please review my work. Thanks :)

  • 👍1
petrspelos commented

Fixed, thank you for contributing. ☺️

  • 😄1