conversejs/converse.js

sass website.css error on first run of make dist

Closed this issue · 1 comments

On the current master branch (e35ad23), when running make dist after a make clean, I get the following error (with possibly unrelated lines for context):

xgettext --from-code=UTF-8 --language=JavaScript --keyword=__ --keyword=___ --keyword=i18n_ --force-po --output=src/i18n/converse.pot --package-name=Converse.js --copyright-holder="Jan-Carel Brand" --package-version=10.1.5 dist/converse-no-dependencies.js -c 2>&1 > /dev/null; exit $?;
dist/converse-no-dependencies.js:77075: warning: unterminated string
dist/converse-no-dependencies.js:77312: warning: unterminated string
rm dist/converse-no-dependencies.js
rm dist/tmp.css
./node_modules/.bin/sass --load-path=./node_modules/ src/shared/styles/website.scss dist/website.css
Error: Undefined variable.
   ╷
21 │   @each $color, $value in $theme-colors-rgb {
   │                           ^^^^^^^^^^^^^^^^^
   ╵
  bootstrap/scss/_root.scss 21:27     @import
  src/shared/styles/website.scss 4:9  root stylesheet
make: *** [Makefile:168: dist/website.css] Error 65

Running make dist again, I don’t get the error anymore, but I’m unsure if this means I’m missing something in my build.
It can be reproduced again by running make clean, then make dist.

b0341f1 appears to fix it.