coolAlias/DynamicSwordSkills

[1.12.2][Latest mod version] Back Slice issues + NullPointer exception.

Closed this issue · 0 comments

I just ran into an issue with Back Slice in the latest 1.12 version. Basically when you successfully proc the effect to knock the armor off a mob, you get the below VanillaFix crashlog(but the game doesn't actually crash) and instead of the armor flying off the mob a duplicate gets spawned on the ground, but the mob keeps his original armour. Tested with Iron Armor on vanilla zombies. I specifically checked to see if it occurs without any mods other than DSS(everything in the crash report shouldn't interfere anyway) - it does.

Other than that the mod works pretty much flawlessly!

Here is the crash log.

Crash report

---- Minecraft Crash Report ----
// Who set us up the TNT?

Time: 2020-11-16 22:14:19 MSK
Description: Error executing task

java.util.concurrent.ExecutionException: java.lang.NullPointerException: The validated object is null
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at net.minecraft.util.Util.runTask(SourceFile:531)
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:723)
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:668)
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:185)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException: The validated object is null
at org.apache.commons.lang3.Validate.notNull(Validate.java:225)
at org.apache.commons.lang3.Validate.notNull(Validate.java:206)
at net.minecraft.util.NonNullList.set(SourceFile:49)
at net.minecraft.entity.EntityLiving.setItemStackToSlot(EntityLiving.java:916)
at dynamicswordskills.skills.BackSlice.postImpact(BackSlice.java:332)
at dynamicswordskills.entity.DSSPlayerInfo.onPostImpact(DSSPlayerInfo.java:449)
at dynamicswordskills.DSSCombatEvents.onPostHurt(DSSCombatEvents.java:195)

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_129_DSSCombatEvents_onPostHurt_LivingHurtEvent.invoke(.dynamic)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
at net.minecraftforge.common.ForgeHooks.onLivingHurt(ForgeHooks.java:604)
at net.minecraft.entity.EntityLivingBase.damageEntity(EntityLivingBase.java:1410)
at net.minecraft.entity.EntityLivingBase.attackEntityFrom(EntityLivingBase.java:926)
at net.minecraft.entity.monster.EntityMob.attackEntityFrom(EntityMob.java:70)
at net.minecraft.entity.monster.EntityZombie.attackEntityFrom(EntityZombie.java:233)
at net.minecraft.entity.player.EntityPlayer.attackTargetEntityWithCurrentItem(EntityPlayer.java:1328)
at net.minecraft.entity.player.EntityPlayerMP.attackTargetEntityWithCurrentItem(EntityPlayerMP.java:1425)
at net.minecraft.network.NetHandlerPlayServer.processUseEntity(NetHandlerPlayServer.java:1092)
at net.minecraft.network.play.client.CPacketUseEntity.processPacket(SourceFile:69)
at net.minecraft.network.play.client.CPacketUseEntity.processPacket(SourceFile:13)
at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at net.minecraft.util.Util.runTask(SourceFile:529)
... 5 more

A detailed walkthrough of the error, its code path and all known details is as follows:

-- System Details --
Minecraft Version: 1.12.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 5996006776 bytes (5718 MB) / 6442450944 bytes (6144 MB) up to 6442450944 bytes (6144 MB)
JVM Flags: 12 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx6144m -Xms256m -XX:PermSize=256m -XX:+UseG1GC -Xmx6G -Xms6G -XX:+UnlockExperimentalVMOptions -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP 9.42 Powered by Forge 14.23.5.2854 14 mods loaded, 14 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored

   | State  | ID                 | Version      | Source                              | Signature                                |
   |:------ |:------------------ |:------------ |:----------------------------------- |:---------------------------------------- |
   | LCHIJA | minecraft          | 1.12.2       | minecraft.jar                       | None                                     |
   | LCHIJA | mcp                | 9.42         | minecraft.jar                       | None                                     |
   | LCHIJA | FML                | 8.0.99.99    | forge-1.12.2-14.23.5.2854.jar       | e3c3d50c7c986df74c645c0ac54639741c90a557 |
   | LCHIJA | forge              | 14.23.5.2854 | forge-1.12.2-14.23.5.2854.jar       | e3c3d50c7c986df74c645c0ac54639741c90a557 |
   | LCHIJA | crafttweaker       | 4.1.20       | CraftTweaker2-1.12-4.1.20.586.jar   | None                                     |
   | LCHIJA | armoreablemobs     | 1.1.2        | armoreablemobs-1.12.2-1.1.8.jar     | None                                     |
   | LCHIJA | ctgui              | 1.0.0        | CraftTweaker2-1.12-4.1.20.586.jar   | None                                     |
   | LCHIJA | mtlib              | 3.0.6        | MTLib-3.0.6.jar                     | None                                     |
   | LCHIJA | modtweaker         | 4.0.18       | modtweaker-4.0.18.jar               | None                                     |
   | LCHIJA | jei                | 4.16.1.301   | jei_1.12.2-4.16.1.301.jar           | None                                     |
   | LCHIJA | crafttweakerjei    | 2.0.3        | CraftTweaker2-1.12-4.1.20.586.jar   | None                                     |
   | LCHIJA | swordskillsapi     | 1.12.2-1.5.1 | SwordSkillsApi-1.12.2-1.5.1.jar     | None                                     |
   | LCHIJA | dynamicswordskills | 1.12.2-6.2.1 | DynamicSwordSkills-1.12.2-6.2.1.jar | None                                     |
   | LCHIJA | vanillafix         | 1.0.10-150   | VanillaFix-1.0.10-150.jar           | None                                     |

Loaded coremods (and transformers): VanillaFixLoadingPlugin (VanillaFix-1.0.10-150.jar)
GL info: ERROR RuntimeException: No OpenGL context found in the current thread.
Suspected Mods: Dynamic Sword Skills (dynamicswordskills)

Submitted a PR for a fix, but it has other stuff too, I'm dumb.