"inURL" url targeting no longer needed?

Question

"inURL" url targeting no longer needed?

Closed this issue 10 years ago · 4 comments

DFP now supports "contains" and "begins with" operators in custom criteria targeting. Does this remove the need for the 'inURL' targeting option in jquery.dfp?

Answer 1 · 2015-03-24T23:50:25.000Z

Looks like you might be right... I will take a closer look when I get a bit more time and see if this can be tidied up without losing any functionality. 😄

Answer 2 · 2015-03-25T07:04:22.000Z

@coop182 I couldn't find any reference to this functionality in the DFP docs, so I'll be doing some testing today and post my findingsin this thread. Furthermore this would definitely be a breaking change jquery.dfp so it might mean the version have to be bumped to 2.0.0?

Answer 3 · 2015-03-25T09:29:23.000Z

Yeah it would definitely be a major version bump... I probably wont get time to look at this until the weekend at this stage.

Answer 4 · 2015-03-25T09:37:51.000Z

@coop182 I will implement the change (remove the inURL functionality), test it and send a pull request. later today (I'm in UTC+1). Then you can merge it or use it as a base when you get the time to take a look at it.

Btw, I'm thinking that there might be some other breaking changes and cleanup tasks (like naming changes etc.) that would be nice to do at the same time if you're going to do a major version bump. I have a few suggestions. Maybe we could start a new version 2.0.0 issue and discuss it there.