coopTilleuls/CoopTilleulsSyliusClickNCollectPlugin

Overriding Location Entity

Closed this issue · 1 comments

Hi,

I believe the Traits ClickNCollectShippingMethod and ClickNCollectShipment should type-hint LocationInterface instead of Location in order to be able to override the Location entity properly?

Example (in Entity/ClickNCollectShippingMethod):
public function addLocation(Location $location): void

should be :

public function addLocation(LocationInterface $location): void

Good catch indeed! I'll fix this.