User Management Panel UI
Closed this issue · 6 comments
as-is: only display components if the user has identifier
to-be: display components if project supports identifier. If user doesn't have the identifier, add an option to add it
as-is: only display components if the user has identifier to-be: display components if project supports identifier. If user doesn't have the identifier, add an option to add it
Need to add a new public frontend api v2 endpoint that returns which identifier types (+ full name) are enabled?
Options:
- New endpoint getSupportedIdentifierTypes(fullNameRequired, identifierConfig, socialConfig). Is this too much information for a public API endpoint? Can be limited to array of identifierTypes and array of socialProviderTypes.
- Add the fields as optional fields to the existing GetSessionConfig in fapiv2
At first I thought the updated @corbado/types code needs to be published to npm registry, but it seems the issue is bigger than that:
Simply using LoginIdentifierType from packages/react breaks the lerna build command. If I add @corbado/types to packages/react/webpack.prod.js and packages/web-js/tsconfig.bundler.json, lerna build is fixed but running react playground fails.
Since everything works correctly outside this branch, it seems that modifying interdependent packages (react, shared-ui, types) simultaneously seems to cause the problem. Is there a best-practice for this that i'm not aware of?
At first I thought the updated @corbado/types code needs to be published to npm registry, but it seems the issue is bigger than that:
Simply using LoginIdentifierType from packages/react breaks the lerna build command. If I add @corbado/types to packages/react/webpack.prod.js and packages/web-js/tsconfig.bundler.json, lerna build is fixed but running react playground fails.
Since everything works correctly outside this branch, it seems that modifying interdependent packages (react, shared-ui, types) simultaneously seems to cause the problem. Is there a best-practice for this that i'm not aware of?
It works when I use LoginIdentifierType from shared-ui instead of from corbado/types... why??? :(
-
Improve the UI together with @Dopeamin => TODO: make a list of required changes
-
Check for usage of translations (compare with PasskeyList)
-
Include into previewui
-
Think about documentation in README.mds of the javascript repo and in docs.corbado.com (compare with PasskeyList)
-
Think about pentesting
todos for changes to the UI
- fix and use css variables in user.css
- proper coloring for light/dark modes (i guess this point is enabled by point 1)
- import the email+phone verification UI from login flow
- modularize name, username, email, and phone cards into different components/files like in passkeylist?
- create dropdown menu for "verify" and "delete" options for each email/phone
- ensure smooth responsive design
- add confirmation dialogs for when deleting an identifier, or deleting the account, as shown in figma
- handle what happens after successful account deletion (not specified in figma. direct to a confirmation page? go straight to login page?)
- generally improve every component to match the figma design (regarding size, padding, border, etc.)