coreybutler/nvm-windows

[Issue]: Missing newline in `nvm uninstall` message

500-internal-server-error opened this issue · 2 comments

What happened?

The message after nvm uninstall is missing a newline.

What did you expect to happen?

The message after nvm uninstall should have a newline, like all the other messages.

Version

1.1.11 or newer (Default)

Which version of Windows?

Windows 11+

Which locale?

English (Default)

Which shell are you running NVM4W in?

Cygwin

User Permissions?

I don't know (Default)

Is Developer Mode enabled?

Yes

Relevant log/console output

user@localhost:~ $ nvm uninstall v21.5.0
Uninstalling node v21.5.0... done%
user@localhost:~ $ # The trailing % sign indicates a missing newline
user@localhost:~ $

Debug Output

User is not using admin or elevated rights.

nvm
Windows Developer Mode: UNKNOWN (user cannot read registry)

NVM4W Version:      1.1.11
NVM4W Path:         C:\Users\User\Applications\nvm4w\nvm.exe
NVM4W Settings:     C:\Users\User\Applications\nvm4w\settings.txt
NVM_HOME:           C:/Users/User/Applications/nvm4w
NVM_SYMLINK:        C:\Users\User\Applications\nodejs
Node Installations: C:\Users\User\Applications\nvm4w

Active Node.js Version: v21.6.1

PROBLEMS DETECTED
-----------------
"nvm" is not an officially supported shell. Some features may not work as expected.



Find help at https://github.com/coreybutler/nvm-windows/wiki/Common-Issues

Anything else?

Shouldn't be relevant, but running zsh from MSYS2 (which is a derivative of Cygwin) in the new Windows Terminal. I suspect Windows cmd will not show any indication of the missing newline.

fmt.Printf(" done")

Seems pretty easy to fix, either add an explicit \n to the Printf or replace it with a regular Print.

Not that it's a critical bug, but it would be nice to fix :)

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

This issue was closed because it has been stalled for 7 days with no activity.