coryodaniel/k8s

Remove accepting params to run/N

coryodaniel opened this issue · 0 comments

opts will need to be kept to pass in certain options to the HTTP provider.

  • Query params were moved to operations in 0.5.1 and deprecated as an option to runners.

  • stream_to for watch is an example of where this doesn't back-out to Operation.query_params well...

  • Middleware will need to separate the concept of adapter options and HTTP params.

  • opts and query_params should be treated as separate things until being merged in the HTTP provider

  • query params should be a kwl

  • Handle conditionally serializing K8s.Selector in query_string labelSelector when calling Base.run/N if its a K8s.Selector struct

  • Consider if K8s.Selector will need to be put into query_string instead of the label_selector key of K8s.Operation when composing selectors

  • Update docs on providing query params and http options