coryrylan/ngx-lite

Update to Angular 13 and beyond?

Closed this issue · 3 comments

akaustav commented

@coryrylan - Are there any plans to support Angular 13 and beyond?
When attempting to install @ngx-lite/json-ld@0.6.4 on an Angular 13 repository, the following error is thrown:

C:\path\to\angular13-repository>npm i @ngx-lite/json-ld
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: angular13-repository@0.0.0
npm ERR! Found: @angular/common@13.3.12
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~13.3.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^12.0.2" from @ngx-lite/json-ld@0.6.4
npm ERR! node_modules/@ngx-lite/json-ld
npm ERR!   @ngx-lite/json-ld@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
akaustav commented

@coryrylan - I just noticed that you have merged PR #82 in the last 24 hours that upgrades compatibility to Angular 14. Thank you and the creator of PR #82. Hopefully, the new release will fix this issue.

Meanwhile, I am not sure about your versioning practices (as asked in #59). I implore you to:

  1. Release a version that is compatible with both Angular 13 and Angular 14. Or release 2 versions - one compatible with Angular 13 and another compatible with Angular 14.
  2. If you are open to the idea, align the versions of the packages originating from this repository to the major versions of Angular:
    1. Release v13.0.0 that is compatible with Angular 13.
    2. Release v14.0.0 that is compatible with Angular 14.
    3. And so on.
  • 👍1
akaustav commented

@coryrylan / @NicolasR - Thank you for finally releasing v14.0.0 of the packages for this repository - including @ngx-lite/json-ld. However, the latest release leaves a hole in support for Angular 13 repositories - see below for the new error thrown by npm now. Are there any plans for releasing a set of v13.0.0 packages that will be compatible with Angular 13 projects?

C:\path\to\angular13-repository>npm i @ngx-lite/json-ld
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: angular13-repository@0.0.0
npm ERR! Found: @angular/common@13.3.12
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~13.3.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^14.2.12" from @ngx-lite/json-ld@14.0.0
npm ERR! node_modules/@ngx-lite/json-ld
npm ERR!   @ngx-lite/json-ld@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
akaustav commented

A version 13.0.0 of this package was published on Feb 25, 2023 from the v13 branch.
See the diff of v13 branch to master and the version 13.0.0 published on npm.
Hence, closing this issue.