Exoplanets not showing correctly in Chrome
Closed this issue · 3 comments
I spotted that in Chrome ( 50.0.2661.94 on Mac OS X 10.10.5) the exoplanets were all showing up blue (I assume color.blue[0] as that's set at the start:
Problem seemed to be in svg.selectAll("circle") with error complaining about negative value of attr "r" being <0 (in the case where a planet has d.radius=0). I have a catch to pick up r=0 and return 0 (not <0).
For some reason, the Chrome console error has stopped appearing (are you currently tinkering @slowe ?), but the planets still show up as blue. Can't seem to check local version in Chrome due to sadboxing restrictions.
@chrisnorth Two people had mentioned all-blue images but I hadn't been able to find the common issue. Unfortunately I can't check Chrome any more as it no longer "supports" my OS. I'm not tinkering with it at the moment. The only thing I changed recently was to update the CSV file with the list of planets.
Was there a radius=0 in there?
+----------------------------------------------------------+
| Dr Chris North
| Research Associate, Undergraduate Admissions Tutor &
| Community Engagement Coordinator
| School of Physics and Astronomy, Cardiff University
| chris.north@astro.cf.ac.uk
| +44 (0)29 208 70537
+----------------------------------------------------------+
On 11 May 2016 at 09:54, Stuart Lowe notifications@github.com wrote:
@chrisnorth https://github.com/chrisnorth Two people had mentioned
all-blue images but I hadn't been able to find the common issue.
Unfortunately I can't check Chrome any more as it no longer "supports" my
OS. I'm not tinkering with it at the moment. The only thing I changed
recently was to update the CSV file with the list of planets.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5 (comment)
It seems the radius isn't the issue at all. The problem is that Chrome isn't finding the background-color for the appropriate discovery method. i.e. $("<div class='transit'></div>").css('backgroundColor') isn't returning what it should be.