cosmos/cosmos-sdk

Rename Msg.Name() to Msg.MsgType() and Msg.Type() to Msg.MsgRoute()

sunnya97 opened this issue · 7 comments

sunnya97 commented

Can we rename the method .Name() on the Msg interface? The field Name is something that many modules may want to use and it can be hard to come up with a good synonym for it. i.e. this broke my nameservice module

ValarDragon commented

I propose changing the Name method to Type and the Type method to Route

sunnya97 commented

I proposer Name -> MsgType and Type -> MsgRoute

  • 👍3
  • 👎1
cwgoes commented

I proposer Name -> MsgType and Type -> MsgRoute

Three thumbs up, seems past the threshold of "proposal-accepted" - sounds good to me!

fedekunze commented

Msg.MsgType() and Msg.MsgRoute() seem redundant to me. Why not just Msg.Type() and Msg.Route() ?

ValarDragon commented

I agree with @fedekunze. I don't think we should prepend msg either. I think it is reasonable to reserve Type and Route as methods on message types. I highly doubt that it will inconvenience that many people, whereas MsgType and MsgRoute does seem confusing.

mossid commented

If we had .Name() it would make the struct unable to contain Name field. Since Name is likely to be used in various situations, it makes sense to rename it to MsgName(). However we already have type keyword in golang and the name Route will not be used widely like as Name, I think we can assume both will not be used in the structs, so it is safe to rename it to Type() and Route().

  • 👍1
cwgoes commented

I'm fine with .Type() and .Route() too, either option is better that what we have at the moment.