cosmos/ibc-proto-rs

Derive serde's `Serialize` and `Deserialize` for structs in `ibc-proto::ibc::core` and `ibc_proto::ibc::applications`

Wizdave97 opened this issue · 6 comments

Wizdave97 commented

Summary

Hello, we need serde's Serialize and Deserialize implemented for some structs in the ibc-proto::ibc module, these structs are being used in our rpc interface so they need to implement the Serialize and Deserialize traits.

Problem Definition

Are there any disadvantages of including this feature? --> No

Proposal

Serialize and Deserialize should be implemented for structs in the ibc_proto::ibc::core and ibc_proto::ibc::applications modules when std is enabled

Acceptance Criteria

All structs in ibc_proto::ibc::core and ibc_proto::ibc::applications have Deserialize and Serialize implemented when std is enabled

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Wizdave97 commented

@romac could this be implemented in the next release, open to working on it.

romac commented

Sure, happy to release it for 0.13.0 if you can open a PR by the end of the week :)

  • 👍1
Wizdave97 commented

Sure, happy to release it for 0.13.0 if you can open a PR by the end of the week :)

@romac Is any of the code in the ibc -proto module auto generated?

romac commented

All of it, except for https://github.com/informalsystems/ibc-rs/blob/master/proto/src/lib.rs is generated by the proto-compiler CLI which is called manually from scripts/sync-protobuf.sh when we need to update the proto definitions.

Wizdave97 commented

Okay, thank you