Sort object before converting sign msg to bytes

Question

Sort object before converting sign msg to bytes

cbarraford opened this issue 5 years ago · 2 comments

I noticed that I ran into a signing verification error when my msg contains an object (like sdk.Coins, which is an array of objects). Because JSON'ifying an object is non-deterministic, the bytes array isn't deterministic when signing a message.

The binance chain JS code sorts the object as seen here. https://github.com/binance-chain/javascript-sdk/blob/75d955eecb6357940f4b3085821a1edbe22513b5/src/encoder/index.js#L72

Maybe this code base should do something similar.

Answer 1 · 2019-07-08T01:20:02.000Z

I will add sortObject() too!

Answer 2 · 2019-07-08T04:17:51.000Z

I added it.
c1b2c13