ERC20 tokens with ERC721 transfers
Closed this issue · 2 comments
fhenneke commented
Stange tokens have been traded a few times last accounting period. Those tokens which combine transfers of ERC20 tokens with transfers of ERC721 tokens. It breaks our slippage accounting since it does not emit Transfer events (but ERCTransfer events?). Those are not handled correctly by our dune slippage query nor by our internalized imbalances code.
This is an example of a settlement with PANDORA. This is an example with MNRCH.
An example of a settlement with internalized PANDORA trades is this.
bh2smith commented
Looks like this could be closed since the reference PR has been merged. Note that you can write "closes #X" in the PR description and GitHub will automatically close the issue once merged.