cpea2506/one_monokai.nvim

feature: disable italics

Closed this issue · 5 comments

alyzmal commented

Is your feature request related to a problem? Please describe.

I love the colors of this colorscheme, but I'm frustrated by the effect that the characters in italics have on their neighbors.

Describe the solution you'd like

A blanket Lua setting to disable italics would be a very convenient way to solve this frustration.

Describe alternatives you've considered

I have debated individually looking through the code to determine which highlight groups are italicized, but this would largely be ineffective and clutter up my personal configuration.

Additional context

No response

cpea2506 commented

If I was right, you would want an option to disable all italics, like this:

require("one_monokai").setup({
	italics = false,
})

This will disable all italics and you will need to use themes options to enable italic for some of highlight groups. Am I right?

alyzmal commented

That is exactly what I'm after! I'm glad it was clear enough.

cpea2506 commented

Thank you! All now done via #57 and it has been merged. You can now update and try it. If there is any problem araises, please let me know in other issue. 😄

alyzmal commented

I'm sure it will work, I just need to wait for the NixNeovimPlugins Nix flake to recognize the update. It might require a version update, as it appears that the last time the plugin's flake was updated was on April 29, when version 1.2.0 of this plugin was released.

alyzmal commented

The flake has finally updated and everything is working great! Thank you so much for your quick response and efforts!

  • 😄1