I have found a bug in ToHex function.

Question

I have found a bug in ToHex function.

mkornaukhov03 opened this issue 3 years ago · 3 comments

Hi! It seems there is a bug: https://github.com/cpeditor/lsp-cpp/blob/master/include/LSPUri.hpp#L100
I suppose the line is going to be return ch > 9 ? ch + 65 : ch + 48;, because 65 (not 55) - is ASCII code for 'A' letter.

Answer 1 · 2021-02-15T18:33:15.000Z

Yes this indeed is a bug. However, the library still works because the URI is rarely encoded in hex, unless file path has some very special characters in it.

Answer 2 · 2021-02-16T01:21:31.000Z

This was actually fixed in the upstream: alextsao1999/lsp-cpp@6b973f8.

We could merge the upstream.

Answer 3 · 2021-02-16T03:34:05.000Z

It seems that the upstream changes don't compile by simply copy-pasting. I'll fix this then.