cpssd-students/steely

Fix .clap

Closed this issue · 10 comments

izaakf commented

is broken

byxor commented

Get 👏 this 👏 fixed 👏 ASAP! 👏

izaakf commented

We 👏 are 👏 going 👏 to 👏 build 👏 a 👏 wall 👏 and 👏 make 👏 them 👏 pay 👏 for 👏 it!

byxor commented

@sentriz Is this fixed? It seems to be working in the chat.

izaakf commented

it doesn't work for things like:
. .

  • 👍1
iandioch commented

What's the desired output for a__b (ie, multiple spaces between things). Is it:

  1. a_👏_b (ie. spaces are joined together)
  2. a_👏_👏_b (ie. each space gets its own clap)
  3. a_👏__b (ie. the extra space is kept but there's a clap too)

IMO (1) above looks best, and also has an easy implementation of just splitting the input string by _, then joining up all parts of len > 0 with a _👏_. No dorty regular expressions.

byxor commented
  1. a_👏_b 👏
  • 👎1
iandioch commented

Haha

seriously though

byxor commented

I am serious. I think the claps should at least be mapped to each word, if not each syllable. Having to subtract 1 feels unnatural to me.

iandioch commented

Hahaha

Back in the real world, though

iandioch commented

That's a different issue, tbh, but it seems it can be solved with a complicated per-user clap preference file that I'd be happy to implement.

  • 👍1