craftcms/commerce-omnipay

Payment form names overwritten

jmauzyk opened this issue · 3 comments

jmauzyk commented

Noticing that the createCard() method overwrites the firstName and lastName values from the payment form with name values from the billing address. I think this can cause issues in certain circumstances. For example, a user might set their billing address to an existing home address, but want to use their spouse's card. In certain cases (like with Amex), passing the wrong name could result in the card being declined. Is there any reason the name values from the payment form shouldn't take precedence?

nfourtythree commented

Hi @jmauzyk

This was fixed in 3.0.1 release of this library.

Thank you for bringing it to our attention.

boboldehampsink commented

@nfourtythree this fix now produces this error: Getting unknown property: craft\commerce\models\payments\OffsitePaymentForm::firstName

nfourtythree commented

Hi @boboldehampsink

Thank you for bringing this to our attention. We have pushed out a fix for this with a new release: 3.0.2

Thanks!