craftpip/jquery-confirm

jc.close() doesn't listen to scrollToPreviousElement parameter

ballanz89 opened this issue · 5 comments

ballanz89 commented

I have this piece of code:

               jc = $.dialog({                             
                    theme: 'supervan',                                
                    animation: 'top',                        
                    closeAnimation: 'bottom',                                
                    closeIcon: 'false',
                    scrollToPreviousElement: null,
                    scrollToPreviousElementAnimate: null,
                    closeIconClass: 'hidden',
                    title: 'My title',
                    content: 'My content',
                    onOpen: function(){
                        setTimeout(function() {
                            if (myFunction()) {
                               jc.close();
                                return false;
                            } 
                        }, 1000); 
                    },
                    onDestroy: function () {
                        $.confirm({                                
                            theme: 'supervan',
                            escapeKey: true,
                            animation: 'top',                        
                            closeAnimation: 'bottom',
                            scrollToPreviousElement: null,
                            scrollToPreviousElementAnimate: null,
                            backgroundDismiss: true,
                            title: 'My title',
                            content: "My content",
                            buttons: {
                                continua: function () {                                        
                                    return true;
                                }                                
                            }
                        }); 
                    },
               });

When I call the .close API it still scrolls to the top of the page.

craftpip commented

Looks like, it could not find the element, i will look into this

  • 👍2
craftpip commented

Fixed 👍

ballanz89 commented

Great! Thank you 👍 May I ask you when the new version will be available?

craftpip commented

Really soon, by today itself.

  • 👍1
craftpip commented

Fixed in v3.2.0