craigburke/client-dependencies-gradle

Circular dependencies should not result in an exception

dtanzer opened this issue · 0 comments

This build script

plugins {
    id "com.craigburke.client-dependencies" version "1.1.4"
}

clientDependencies {
    installDir = 'src/main/resources/static/vendor'

    npm {
        'react' ('15.x.x')
        'react-dom' ('15.x.x')
        'babelify' ('7.3.0')
        'babel-preset-react' ('6.x.x')
    }
}

throws the following exception:

* What went wrong:
Execution failed for task ':web-frontend:clientReport'.
> com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: Circular dependency created by dependency babel-types@^6.9.0

It seems like circular dependencies are supported by npm, so they should also be supported by the client dependencies plugin.