Doesn’t work with Rails 6

Question

Doesn’t work with Rails 6

Closed this issue 4 years ago · 10 comments

Just letting you know that this gem doesn’t work with Rails 6 yet, due to some major changes in the AR schema API. I’m working on updating it and will hopefully have a pull request fairly soon.

Answer 1 · 2019-12-06T00:13:10.000Z

Hey @marnen! Thanks for letting me know. If I can help in any way, if you need some guidance, just let me know.

Answer 2 · 2019-12-06T12:36:29.000Z

Thanks! The change in API has made this a bit of a drag, but I’ll be back in touch with you with questions when I have more time to spend on it.

Answer 3 · 2019-12-17T02:10:06.000Z

@marnen I just released a new version, which might not affect your changes, unless most of them are related to array associations. Let me know how I can help, even if it's just for some guidance.

Answer 4 · 2019-12-17T04:17:34.000Z

Thanks for the update. I need to get back to working on this, if I even bother. I’m only using Torque for duration support, so it may not be worth it for me, but OTOH I do want Torque to be available for Rails 6 projects and no one else seems to be making that happen.

I’ve implemented a few things already; perhaps I should push the current changes for your review before going further.

Answer 5 · 2019-12-17T17:34:30.000Z

I think that's a good idea, and I can also help you to do the fixes for Rails 6. I was thinking that maybe event creating the v2.0.0 exclusively for Rails 6+, removing backward compatibility (but maintaining both versions 1 and 2, for a while).

Just a question, any reason why not use the other features available? I have a bunch of other features that I want to add, but not quite sure which one to pursue. Maybe the recursive CTEs.

Answer 6 · 2019-12-17T18:13:03.000Z

I was thinking that maybe event creating the v2.0.0 exclusively for Rails 6+, removing backward compatibility

Yes, that may have to happen. There are some fairly big changes in ActiveRecord 6.

any reason why not use the other features available?

So far I haven't needed them for anything I'm doing. Also, I only recently found out about this gem in the first place. :)

Answer 7 · 2019-12-22T08:53:56.000Z

I might start some work towards Rails 6 in the next days (a new project came up, so it would be ideal to have the GEM in this project which uses Rails 6). Let me know if you can share what you have.

Answer 8 · 2019-12-24T12:35:43.000Z

Sure. I’ll try to do that over Christmas. Thanks for the reminder.

(BTW: it’s “gem”, not “GEM”. It’s an ordinary English word, not an acronym. :) )

Answer 9 · 2019-12-27T22:12:43.000Z

I just pushed my work at https://github.com/marnen/torque-postgresql/tree/rails-6-wip. Enjoy!

Answer 10 · 2020-06-18T20:03:04.000Z

The new version 2 now works on Rails 6.