crate/crate-java-testing

File is downloaded to /tmp

mjwall opened this issue · 4 comments

https://github.com/crate/crate-java-testing/blob/master/src/main/java/io/crate/testing/CrateTestCluster.java#L51

Most systems clear out that directory periodically. If I had the option to save under a directory in ~/, I would use that.

hi @mjwall, thanks for the suggestion. at the moment we won't implement that, but that's something that probably won't be to hard to contribute. so if you want to do that, we'd be happy to assist.

thanks, joe

@joemoe if I replace /tmp with ~/.crate-installer would that work?

Or do you want it configurable? If configurable do you have a preference or crate convention on how that would be configured?

seut commented

@mjwall in most cases it is highly appreciated that the data directory is inside a temp folder which will be purged by the os. To also address your use case, it would be best to make changing this folder optional. E.g. by reading an env variable and falling back to the existing temp folder if not set.

thanks @seut. I agree the data directory inside of /tmp is nice. I just didn't want to have to download crate again in 2 weeks over my slow network connection :). I'll see about making the download directory configurable with an environment variable.