Code dependency
Closed this issue · 1 comments
adhocore commented
https://github.com/crazyfactory/validation/blob/master/composer.json#L17
{
"require": {
"crazyfactory/harmonized-system": "^2.3"
}
}
we shouldnt depend on private pkg from public pkg
the specific validator must throw exception when harmonized-system
is not installed. (!class_exists('SomeHarmonicClass')
)
the crazyfactory/harmonized-system
should be in "suggest"
section of crazyfactory/validation
pkg
adhocore commented
fixed already