crisp-im/node-crisp-api

findWithSearch is double encoding the query parameters, which is corrupting the search query in some cases.

bdevore17 opened this issue · 5 comments

bdevore17 commented

node-crisp-api/lib/resources/WebsiteConversations.js

Line 61 in 5fcba72

query[parameter[1]] = encodeURIComponent(parameterValue);

got is already encoding query parameters, so it is harmful to do it ahead of time.

bdevore17 commented

For example, a search query of +1 is being encoded into %252B1 instead of %2B1

bdevore17 commented

@eliottvincent Can you please cut a new release with this fix?

eliottvincent commented

Sure!

bdevore17 commented

Thank you!